Messages in this thread | | | Date | Fri, 11 Nov 2022 14:58:45 +0000 | From | Sakari Ailus <> | Subject | Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data |
| |
On Fri, Nov 11, 2022 at 02:08:48PM +0200, Andy Shevchenko wrote: > On Fri, Nov 11, 2022 at 02:05:37PM +0200, Andy Shevchenko wrote: > > On Tue, Aug 23, 2022 at 05:10:35PM +0300, Andy Shevchenko wrote: > > > On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote: > > > > The struct i2c_client pointer is used only to get driver data, > > > > associated with a struct device or print messages on behalf. > > > > Moreover, the very same pointer to a struct device is already > > > > assigned by a regmap and can be retrieved from there. > > > > No need to keep a duplicative pointer. > > > > > > Thanks, Bungbu, for the review. Can it be now applied? > > > > Don't see this being applied or commented why not... > > > > Mauro? Or who is taking care of this driver nowadays? > > Okay, found a private response by Mauro where he tells that Sakari can take > care of this. Sakari, should I resend this to you with all tags applied? > Or you can use `b4` tool that allows to avoid unneeded resend.
No need to. But please cc me on the next time. I'll take a look now...
-- Sakari Ailus
| |