lkml.org 
[lkml]   [2022]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 11/20] dt-bindings: PCI: dwc: Add clocks/resets common properties
On Thu, Nov 10, 2022 at 03:23:37PM -0600, Rob Herring wrote:
>
> On Mon, 07 Nov 2022 23:49:25 +0300, Serge Semin wrote:
> > DW PCIe RP/EP reference manuals explicit define all the clocks and reset
> > requirements in [1] and [2]. Seeing the DW PCIe vendor-specific
> > DT-bindings have already started assigning random names to the same set of
> > the clocks and resets lines, let's define a generic names sets and add
> > them to the DW PCIe common DT-schema.
> >
> > Note since there are DW PCI-based vendor-specific DT-bindings with the
> > custom names assigned to the same clocks and resets resources we have no
> > much choice but to add them to the generic DT-schemas in order to have the
> > schemas being applicable for such devices. These names are marked as
> > vendor-specific and should be avoided being used in new bindings in favor
> > of the generic names.
> >
> > [1] Synopsys DesignWare Cores PCI Express Controller Databook - DWC PCIe
> > Root Port, Version 5.40a, March 2019, p.55 - 78.
> > [2] Synopsys DesignWare Cores PCI Express Controller Databook - DWC PCIe
> > Endpoint, Version 5.40a, March 2019, p.58 - 81.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > ---
> >
> > Changelog v3:
> > - This is a new patch unpinned from the next one:
> > https://lore.kernel.org/linux-pci/20220503214638.1895-2-Sergey.Semin@baikalelectronics.ru/
> > by the Rob' request. (@Rob)
> > - Drop synonymous from the names list since the device schemas create
> > their own enumerations anyway.
> >
> > Changelog v5:
> > - Add platform-specific clock/reset names, but mark them as deprecated.
> >
> > Changelog v6:
> > - Move the common *-names definitions to the RP/EP schemas. Thus drop
> > the 'definitions' property. (@Rob)
> > - Drop the 'deprecated' keywords from the vendor-specific names. (@Rob)
> > ---
> > .../bindings/pci/snps,dw-pcie-common.yaml | 120 ++++++++++++++++++
> > .../bindings/pci/snps,dw-pcie-ep.yaml | 6 +
> > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 -
> > 3 files changed, 126 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Yahoo! We've finally done this) Thanks.

-Sergey

\
 
 \ /
  Last update: 2022-11-11 12:05    [W:0.051 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site