lkml.org 
[lkml]   [2022]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 05/10] dt-bindings: interconnect: Add sm8350, sc8280xp and generic OSM L3 compatibles
    From


    On 11/11/22 08:55, Bjorn Andersson wrote:
    > Add EPSS L3 compatibles for sm8350 and sc8280xp, but while at it also
    > introduce generic compatible for both qcom,osm-l3 and qcom,epss-l3.
    >
    > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
    > Tested-by: Steev Klimaszewski <steev@kali.org>
    > ---
    >
    > Changes since v1:
    > - Fixed oneOf to be valid schema
    > - Fixed example to follow schema
    >
    > .../bindings/interconnect/qcom,osm-l3.yaml | 24 ++++++++++++-------
    > 1 file changed, 16 insertions(+), 8 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
    > index bf538c0c5a81..aadae4424ba9 100644
    > --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
    > +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
    > @@ -16,13 +16,21 @@ description:
    >
    > properties:
    > compatible:
    > - enum:
    > - - qcom,sc7180-osm-l3
    > - - qcom,sc7280-epss-l3
    > - - qcom,sc8180x-osm-l3
    > - - qcom,sdm845-osm-l3
    > - - qcom,sm8150-osm-l3
    > - - qcom,sm8250-epss-l3
    > + oneOf:
    > + - items:
    > + - enum:
    > + - qcom,sc7180-osm-l3
    > + - qcom,sc8180x-osm-l3
    > + - qcom,sdm845-osm-l3
    > + - qcom,sm8150-osm-l3
    > + - const: qcom,osm-l3
    > + - items:
    > + - enum:
    > + - qcom,sc7280-epss-l3
    > + - qcom,sc8280xp-epss-l3
    > + - qcom,sm8250-epss-l3
    > + - qcom,sm8350-epss-l3
    > + - const: qcom,epss-l3

    isn't it incorrect to describe qcom,epss-l3 as a working
    backup compatible for sc7280-epss-l3 and sm8250-epss-l3?
    Shouldn't we just add another items list with those 2 as
    enums?

    >
    > reg:
    > maxItems: 1
    > @@ -56,7 +64,7 @@ examples:
    > #define RPMH_CXO_CLK 0
    >
    > osm_l3: interconnect@17d41000 {
    > - compatible = "qcom,sdm845-osm-l3";
    > + compatible = "qcom,sdm845-osm-l3", "qcom,osm-l3";
    > reg = <0x17d41000 0x1400>;
    >
    > clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>;

    \
     
     \ /
      Last update: 2022-11-11 11:33    [W:3.265 / U:0.824 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site