Messages in this thread | | | Date | Fri, 11 Nov 2022 07:08:36 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/2] usb: ulpi: defer ulpi_register on ulpi_read_id timeout |
| |
On Thu, Nov 10, 2022 at 10:11:31PM +0100, Ferry Toth wrote: > Since commit 0f010171 > Dual Role support on Intel Merrifield platform broke due to rearranging > the call to dwc3_get_extcon().
Please see the kernel documentation for how to refer to commits. This should be written as:
Since commit 0f0101719138 ("usb: dwc3: Don't switch OTG -> peripheral if extcon is present"), Dual role....
> It appears to be caused by ulpi_read_id() on the first test write failing > with -ETIMEDOUT. Currently ulpi_read_id() expects to discover the phy via > DT when the test write fails and returns 0 in that case even if DT does not > provide the phy. As a result usb probe completes without phy. > > Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
What commit does this fix?
Should this also get a cc: stable?
thanks,
greg k-h
| |