| Date | Thu, 10 Nov 2022 10:05:57 -0800 | From | Boqun Feng <> | Subject | Re: [PATCH v1 01/28] rust: prelude: split re-exports into groups |
| |
On Thu, Nov 10, 2022 at 05:41:13PM +0100, Miguel Ojeda wrote: > Split the prelude re-exports into groups: first the ones coming > from the `core` crate, then `alloc`, then our own crates and > finally the ones from modules from `kernel` itself (i.e. `super`). > > We are doing this manually for the moment, but ideally, long-term, > this could be automated via `rustfmt` with options such as > `group_imports` and `imports_granularity` (both currently unstable). > > Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards, Boqun
> --- > rust/kernel/prelude.rs | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs > index 495e22250726..f8219285d8c0 100644 > --- a/rust/kernel/prelude.rs > +++ b/rust/kernel/prelude.rs > @@ -11,10 +11,14 @@ > //! use kernel::prelude::*; > //! ``` > > -pub use super::{ > - error::{Error, Result}, > - pr_emerg, pr_info, ThisModule, > -}; > -pub use alloc::{boxed::Box, vec::Vec}; > pub use core::pin::Pin; > + > +pub use alloc::{boxed::Box, vec::Vec}; > + > pub use macros::module; > + > +pub use super::{pr_emerg, pr_info}; > + > +pub use super::error::{Error, Result}; > + > +pub use super::ThisModule; > -- > 2.38.1 >
|