Messages in this thread | | | Date | Thu, 10 Nov 2022 14:35:42 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2 08/14] tools lib perf: Add missing install headers |
| |
Em Wed, Nov 09, 2022 at 12:12:16PM -0800, Namhyung Kim escreveu: > On Wed, Nov 9, 2022 at 10:50 AM Ian Rogers <irogers@google.com> wrote: > > Headers necessary for the perf build. Note, internal headers are also > > installed as these are necessary for the build.
> Yeah, it's sad we are using those internal headers in perf.
The plan is for perf to eventually be a libperf tool, but what was done so far was make available classes and methods that were asked for by libperf users.
Completely untangling tools/perf/ from those internal bits will needs lots more work, so doing it the way Ian is doing now seems ok.
- Arnaldo
> Ideally libperf provides callbacks to associate private data > to each public data structure (e.g. evsel, evlist, etc). And > external users just use public APIs only. > > But that would be a major change.
| |