Messages in this thread | | | Date | Thu, 10 Nov 2022 17:07:44 +0100 | Subject | Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls | From | Juergen Gross <> |
| |
On 10.11.22 16:45, Ross Philipson wrote: > There are a number of places where early_memremap is called > but the return pointer is not checked for NULL. The call > can result in a NULL being returned so the checks must > be added. > > Note that the maintainers for both the Jailhouse and Xen code > approved of using panic() to handle allocation failures. > > In addition to checking the return values, a bit of extra > cleanup of pr_* usages was done since the pr_fmt macro was > introduced in the modules touched by this patch. > > Signed-off-by: Ross Philipson <ross.philipson@oracle.com> > --- > arch/x86/kernel/devicetree.c | 13 +++++++++++ > arch/x86/kernel/e820.c | 12 +++++++++-- > arch/x86/kernel/jailhouse.c | 6 ++++++ > arch/x86/kernel/mpparse.c | 51 +++++++++++++++++++++++++++++++++----------- > arch/x86/kernel/setup.c | 19 ++++++++++++++--- > arch/x86/xen/enlighten_hvm.c | 2 ++ > arch/x86/xen/mmu_pv.c | 8 +++++++ > arch/x86/xen/setup.c | 2 ++ > 8 files changed, 95 insertions(+), 18 deletions(-)
For the Xen parts:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |