Messages in this thread | | | Subject | Re: [PATCH v1] net: macvlan: Use built-in RCU list checking | From | Paolo Abeni <> | Date | Thu, 10 Nov 2022 11:57:22 +0100 |
| |
Hello,
On Tue, 2022-11-08 at 20:52 +0800, Chuang Wang wrote: > hlist_for_each_entry_rcu() has built-in RCU and lock checking. > > Pass cond argument to hlist_for_each_entry_rcu() to silence false > lockdep warning when CONFIG_PROVE_RCU_LIST is enabled. > > Execute as follow: > > ip link add link eth0 type macvlan mode source macaddr add <MAC-ADDR> > > The rtnl_lock is held when macvlan_hash_lookup_source() or > macvlan_fill_info_macaddr() are called in the non-RCU read side section. > So, pass lockdep_rtnl_is_held() to silence false lockdep warning. > > Signed-off-by: Chuang Wang <nashuiliang@gmail.com>
The patch LGTM, but IMHO this should target the -net tree, as it's addressing an issue bothering people.
Can you please re-submit, specifying the target tree into the subj and including a suitable Fixes tag?
Thanks!
Paolo
| |