Messages in this thread | | | From | "Jason A. Donenfeld" <> | Date | Fri, 11 Nov 2022 03:50:12 +0100 | Subject | Re: [PATCH] media: stv0288: use explicitly signed char |
| |
Hi Mauro,
On Wed, Nov 2, 2022 at 3:47 AM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Hi Mauro, > > On Mon, Oct 24, 2022 at 6:28 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > With char becoming unsigned by default, and with `char` alone being > > ambiguous and based on architecture, signed chars need to be marked > > explicitly as such. Use `s8` and `u8` types here, since that's what > > surrounding code does. This fixes: > > > > drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm' > > drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop > > > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > > Was wondering whether you planned on taking this into your tree as a > 6.1 fix for Linus for rc4?
Thought I should follow up with you about this again.
Thanks, Jason
| |