Messages in this thread Patch in this message | | | From | Frank Li <> | Subject | RE: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy | Date | Fri, 11 Nov 2022 02:39:12 +0000 |
| |
> -----Original Message----- > From: Lorenzo Pieralisi <lpieralisi@kernel.org> > Sent: Thursday, November 10, 2022 9:29 AM > To: Frank Li <frank.li@nxp.com> > Cc: mani@kernel.org; allenbh@gmail.com; bhelgaas@google.com; > dave.jiang@intel.com; helgaas@kernel.org; imx@lists.linux.dev; > jdmason@kudzu.us; kw@linux.com; linux-kernel@vger.kernel.org; linux- > pci@vger.kernel.org; ntb@lists.linux.dev > Subject: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > unused field epf_db_phy > > Caution: EXT Email > > On Wed, Nov 02, 2022 at 10:10:11AM -0400, Frank Li wrote: > > From: Frank Li <frank.li@nxp.com> > > > > epf_db_phy is not used, so remove it > > Sentences end with a period (.). I can fix these things but > we can't spend our lives telling you how to write a commit log, > check how they are written in the PCI subsystem and follow the > pattern.
[Frank Li] Do you need me send new version to fix "."? Or you will plan queue these patches?
My means: Mani's below feedback will make both live easy. > > None use epf_db_phy and remove it.
"epf_db_phy is not used, so remove it"
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > ernel.org%2Fall%2F20171026223701.GA25649%40bhelgaas- > glaptop.roam.corp.google.com&data=05%7C01%7CFrank.Li%40nxp.co > m%7Ca0924bed538a494cbfd508dac3304e8e%7C686ea1d3bc2b4c6fa92cd99c > 5c301635%7C0%7C0%7C638036909484154968%7CUnknown%7CTWFpbGZsb > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7C3000%7C%7C%7C&sdata=B3G7sfaSVdLDC8BG95WzpBPFO5lPJ > QpThKDcEexOHfU%3D&reserved=0
[Frank Li] Thank you for your documents.
> > > > > Signed-off-by: Frank Li <frank.li@nxp.com> > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > --- > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c > b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > index 191924a83454..ee66101cb5c4 100644 > > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > @@ -136,7 +136,6 @@ struct epf_ntb { > > > > struct epf_ntb_ctrl *reg; > > > > - phys_addr_t epf_db_phy; > > void __iomem *epf_db; > > > > phys_addr_t vpci_mw_phy[MAX_MW]; > > -- > > 2.34.1 > >
| |