Messages in this thread | | | Date | Tue, 1 Nov 2022 10:45:00 -0500 | Subject | Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support | From | Eric DeVolder <> |
| |
On 10/31/22 16:04, Borislav Petkov wrote: > On Mon, Oct 31, 2022 at 03:36:04PM -0400, Eric DeVolder wrote: >> +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_MEMORY_HOTPLUG) > > What happened to that here: > > https://lore.kernel.org/r/Y1e85gqB3kzlx7qL@zn.tnic > > ? >
When I was evaluating the suggestions, I realized that that particular ifdiffery was now used in only 3 locations, twice in kernel/crash_core.c and once in x86 crash.c.
With that realization, and the fact that we just jettisoned CONFIG_CRASH_MAX_MEMORY_RANGES for a #define, it seemed that there wasn't a compelling need to replace the HOTPLUG_CPU || MEMORY_HOTPLUG with a new CRASH_HOTPLUG Kconfig item.
As I'm re-reading that message, I suspect now the preference is to just to strike this ifdiffery line in this file and have the code always present?
If the preference is actually for CRASH_HOTPLUG, then let me know.
Thanks! eric
| |