Messages in this thread | | | Date | Sun, 9 Oct 2022 19:47:00 +0800 | From | Ming Lei <> | Subject | Re: [PATCH] blk-wbt: fix that 'rwb->wc' is always set to 1 in wbt_init() |
| |
On Sun, Oct 09, 2022 at 06:10:38PM +0800, Yu Kuai wrote: > From: Yu Kuai <yukuai3@huawei.com> > > commit 8c5035dfbb94 ("blk-wbt: call rq_qos_add() after wb_normal is > initialized") moves wbt_set_write_cache() before rq_qos_add(), which > is wrong because wbt_rq_qos() is still NULL. > > Fix the problem by removing wbt_set_write_cache() and setting 'rwb->wc' > directly. Noted that this patch also remove the redundant setting of > 'rab->wc'. > > Fixes: 8c5035dfbb94 ("blk-wbt: call rq_qos_add() after wb_normal is initialized") > Reported-by: kernel test robot <yujie.liu@intel.com> > Link: https://lore.kernel.org/r/202210081045.77ddf59b-yujie.liu@intel.com > Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Looks fine,
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks, Ming
| |