lkml.org 
[lkml]   [2022]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter
Date
On Fri, Oct 07, 2022 at 10:07:06AM +0900, Naoya Horiguchi wrote:
...
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 9aa0da991cfb..5d00d8a14c79 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -175,6 +175,17 @@ int memory_notify(unsigned long val, void *v)
> return blocking_notifier_call_chain(&memory_chain, val, v);
> }
>
> +#if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_MEMORY_HOTPLUG)

> +void memblk_nr_poison_inc(unsigned long pfn);
> +void memblk_nr_poison_sub(unsigned long pfn, long i);

Sorry again, these prototypes should not be necessary. I'll remove these
when I need resubmit the patch series.

It seems that scripts/checkpatch.pl shows the following warning by these.

WARNING: externs should be avoided in .c files
#59: FILE: drivers/base/memory.c:180:
+void memblk_nr_poison_sub(unsigned long pfn, long i);

This disappears by removing the prototypes.

Thanks,
Naoya Horiguchi
\
 
 \ /
  Last update: 2022-10-07 06:35    [W:0.349 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site