Messages in this thread | | | Date | Fri, 7 Oct 2022 12:55:05 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all xHC 1.2 or later devices |
| |
On Thu, Oct 06, 2022 at 04:15:28PM -0500, Mario Limonciello wrote: > - if (pdev->vendor == PCI_VENDOR_ID_AMD && > - (pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_7 || > - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_8))
Can you add a comment here explaining why this is OK? I think it is easier that way to find out why this is here in the future instead of going through the git blame history.
> + if (xhci->hci_version >= 0x102) > xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
| |