lkml.org 
[lkml]   [2022]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
On Fri, Oct 07, 2022 at 09:28:17AM +0800, ChiaEn Wu wrote:
> On Wed, Oct 5, 2022 at 8:15 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> > > +config LEDS_MT6370_FLASH
> > > + tristate "Flash LED Support for MediaTek MT6370 PMIC"
> >
> > > + depends on LEDS_CLASS && OF
> >
> > Why do you have OF dependency?
> >
>
> Hi Andy,
> The original idea is to use the "fwnode_property_*" related function.
> But this side may only consider just "Build Pass" (?)

Yes, you increase a compile test coverage by dropping that dependency.

> I will remove "OF" in the v14 patch.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-10-07 13:28    [W:0.041 / U:2.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site