Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 6 Oct 2022 12:53:32 -0700 | Subject | Re: [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip |
| |
Hi,
On Thu, Oct 6, 2022 at 3:58 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > Add an goodix touch screen chip GT7986U.
In theory you could beef up the commit message explaining that GT7986U is expected to be fully compatible with a driver written for GT7375P, but I wouldn't spin just for that.
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v7: > - goodix gt7986 dt bindings added in v7 > > Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > index fe1c5016f7f31..1c191bc5a1782 100644 > --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > @@ -16,8 +16,11 @@ description: > > properties: > compatible: > - items: > + oneOf: > - const: goodix,gt7375p > + - items: > + - const: goodix,gt7986u > + - const: goodix,gt7375p
I haven't run this through schema validation, but from a visual inspection it looks good to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |