Messages in this thread | | | Date | Wed, 5 Oct 2022 15:42:16 +0200 | Subject | Re: [PATCH 3/5] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema | From | AngeloGioacchino Del Regno <> |
| |
Il 05/10/22 15:38, Rob Herring ha scritto: > On Wed, Oct 05, 2022 at 01:35:15PM +0200, AngeloGioacchino Del Regno wrote: >> Convert the MediaTek watchdog bindings to schema. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../bindings/watchdog/mediatek,mtk-wdt.yaml | 80 +++++++++++++++++++ >> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ---------- >> 2 files changed, 80 insertions(+), 42 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> >> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> new file mode 100644 >> index 000000000000..f43b5af92d40 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> @@ -0,0 +1,80 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/mediatek,mtk-wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek SoCs Watchdog timer >> + >> +maintainers: >> + - Matthias Brugger <matthias.bgg@gmail.com> >> + >> +description: >> + The watchdog supports a pre-timeout interrupt that fires >> + timeout-sec/2 before the expiry. >> + >> +allOf: >> + - $ref: watchdog.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - mediatek,mt2712-wdt >> + - mediatek,mt6589-wdt >> + - mediatek,mt7986-wdt >> + - mediatek,mt8183-wdt >> + - mediatek,mt8186-wdt >> + - mediatek,mt8192-wdt >> + - mediatek,mt8195-wdt > > The original binding only had 4 without a fallback. It's fine to add or > change, but note the changes in the commit msg. Are all of these really > each unique and not the same? >
Ok I will note the changes in the commit for v2. And... yes, they're really each unique and not the same, as these are exposing a reset controller of their own (as well with different platform data in the driver).
> >> + - items: >> + - enum: >> + - mediatek,mt2701-wdt >> + - mediatek,mt6582-wdt >> + - mediatek,mt6797-wdt >> + - mediatek,mt7622-wdt >> + - mediatek,mt7623-wdt >> + - mediatek,mt7629-wdt >> + - mediatek,mt8516-wdt >> + - const: mediatek,mt6589-wdt >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: Watchdog pre-timeout (bark) interrupt >> + >> + mediatek,disable-extrst: >> + description: Disable sending output reset signal >> + type: boolean >> + >> + timeout-sec: true > > Drop this and use 'unevaluatedProperties'. >
Noted. Will do for v2.
Thanks! Angelo
| |