lkml.org 
[lkml]   [2022]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 39/51] xfs: introduce XFS_MAX_FILEOFF
    Date
    From: "Darrick J. Wong" <darrick.wong@oracle.com>

    commit a5084865524dee1fe8ea1fee17c60b4369ad4f5e upstream.

    Introduce a new #define for the maximum supported file block offset.
    We'll use this in the next patch to make it more obvious that we're
    doing some operation for all possible inode fork mappings after a given
    offset. We can't use ULLONG_MAX here because bunmapi uses that to
    detect when it's done.

    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Acked-by: Darrick J. Wong <djwong@kernel.org>
    Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/xfs/libxfs/xfs_format.h | 7 +++++++
    fs/xfs/xfs_reflink.c | 3 ++-
    2 files changed, 9 insertions(+), 1 deletion(-)

    --- a/fs/xfs/libxfs/xfs_format.h
    +++ b/fs/xfs/libxfs/xfs_format.h
    @@ -1540,6 +1540,13 @@ typedef struct xfs_bmdr_block {
    #define BMBT_BLOCKCOUNT_BITLEN 21

    #define BMBT_STARTOFF_MASK ((1ULL << BMBT_STARTOFF_BITLEN) - 1)
    +#define BMBT_BLOCKCOUNT_MASK ((1ULL << BMBT_BLOCKCOUNT_BITLEN) - 1)
    +
    +/*
    + * bmbt records have a file offset (block) field that is 54 bits wide, so this
    + * is the largest xfs_fileoff_t that we ever expect to see.
    + */
    +#define XFS_MAX_FILEOFF (BMBT_STARTOFF_MASK + BMBT_BLOCKCOUNT_MASK)

    typedef struct xfs_bmbt_rec {
    __be64 l0, l1;
    --- a/fs/xfs/xfs_reflink.c
    +++ b/fs/xfs/xfs_reflink.c
    @@ -1544,7 +1544,8 @@ xfs_reflink_clear_inode_flag(
    * We didn't find any shared blocks so turn off the reflink flag.
    * First, get rid of any leftover CoW mappings.
    */
    - error = xfs_reflink_cancel_cow_blocks(ip, tpp, 0, NULLFILEOFF, true);
    + error = xfs_reflink_cancel_cow_blocks(ip, tpp, 0, XFS_MAX_FILEOFF,
    + true);
    if (error)
    return error;


    \
     
     \ /
      Last update: 2022-10-05 13:38    [W:3.209 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site