lkml.org 
[lkml]   [2022]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 2/2] soc: renesas: Add L2 cache management for RZ/Five SoC
On Tue, Oct 4, 2022, at 7:42 PM, Conor Dooley wrote:
> On Mon, Oct 03, 2022 at 11:32:22PM +0100, Prabhakar wrote:
>>
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>> arch/riscv/include/asm/cacheflush.h | 8 +
>> arch/riscv/include/asm/errata_list.h | 2 +
>> arch/riscv/include/asm/sbi.h | 1 +
>> arch/riscv/mm/dma-noncoherent.c | 20 ++
>
> Stupid question maybe, but I assume you mixed the driver addition and
> the changes to arch/riscv for the sake of easily creating the RFC?
>
>> drivers/soc/renesas/Makefile | 4 +
>> drivers/soc/renesas/rzf/Makefile | 3 +
>> drivers/soc/renesas/rzf/ax45mp_cache.c | 365 +++++++++++++++++++++++++
>> drivers/soc/renesas/rzf/rzf_sbi.h | 27 ++

My feeling is that L2 cache behavior should live in arch/riscv
rather than drivers/soc/, since this is not specific to a SoC
family but rather the CPU core. I would also expect that the
actual implementation and DT binding can be shared with
non-renesas SoCs using the same CPU core.


Arnd

\
 
 \ /
  Last update: 2022-10-05 11:58    [W:0.122 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site