Messages in this thread | | | From | <> | Subject | RE: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power management functions to quad-uart driver. | Date | Tue, 4 Oct 2022 17:20:52 +0000 |
| |
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Monday, October 3, 2022 2:57 PM > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com> > Subject: Re: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power > management functions to quad-uart driver. > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Sat, Oct 1, 2022 at 9:15 AM Kumaravel Thiagarajan > <kumaravel.thiagarajan@microchip.com> wrote: > > > > pci1xxxx's quad-uart function has the capability to wake up the host > > from suspend state. Enable wakeup before entering into suspend and > > disable wakeup on resume. > > ... > > > + port->suspended == 0 > > How is this check race-protected? > > ... > > > +static void pci1xxxx_port_resume(int line) { > > > + if (port->suspended == 0) { > > Ditto. > > > + } > > +} > > ... > > If you have similarities with 8250_pci, probably you need to split it to > 8250_pcilib.c and share. (See how 8250_dw /8250_lpss are done in that > sense.) I will review my code against all the above comments and get back to you.
Thank You.
Regards, Kumar
| |