Messages in this thread Patch in this message | | | Date | Tue, 4 Oct 2022 12:48:19 +0100 | From | Will Deacon <> | Subject | Re: [PATCH linux-next] arm64/idreg: use strscpy() is more robust and safer |
| |
On Thu, Sep 29, 2022 at 07:29:06AM +0000, xu.panda668@gmail.com wrote: > From: Xu Panda <xu.panda@zte.com.cn> > > The implementation of strscpy() is more robust and safer. > That's now the recommended way to copy NUL terminated strings. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Xu Panda <xu.panda@zte.com.cn> > Signed-off-by: Xu Panda <xu.panda668@gmail.com> > --- > arch/arm64/kernel/idreg-override.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c > index 95133765ed29..61bbec7ef62e 100644 > --- a/arch/arm64/kernel/idreg-override.c > +++ b/arch/arm64/kernel/idreg-override.c > @@ -246,7 +246,7 @@ static __init void __parse_cmdline(const char *cmdline, bool parse_aliases) > return; > > len = min(len, ARRAY_SIZE(buf) - 1); > - strncpy(buf, cmdline, len); > + strscpy(buf, cmdline, len); > buf[len] = 0;
Aren't we terminating the buffer explicitly here anyway?
Will
| |