Messages in this thread | | | Date | Mon, 31 Oct 2022 13:56:38 -0700 | From | Mike Kravetz <> | Subject | Re: [PATCH 9/9] mm/hugetlb: convert move_hugetlb_state() to folios |
| |
On 10/13/22 20:13, Sidhartha Kumar wrote: > Clean up unmap_and_move_huge_page() by converting move_hugetlb_state() to > take in folios. > > Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com> > --- > include/linux/hugetlb.h | 6 +++--- > mm/hugetlb.c | 22 ++++++++++++---------- > mm/migrate.c | 2 +- > 3 files changed, 16 insertions(+), 14 deletions(-)
Looks fine with one comment,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1328,7 +1328,7 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > put_anon_vma(anon_vma); >
It looks like there is a hugetlb_page_subpool(hpage) in this routine before here that could perhaps be changed to?
hugetlb_folio_subpool(src)
-- Mike Kravetz
> if (rc == MIGRATEPAGE_SUCCESS) { > - move_hugetlb_state(hpage, new_hpage, reason); > + move_hugetlb_state(src, dst, reason); > put_new_page = NULL; > } > > -- > 2.31.1 >
| |