Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH v3] soc: ti: Convert allocations to devm | Date | Mon, 31 Oct 2022 09:34:22 -0700 |
| |
Nishanth Menon <nm@ti.com> writes:
> On 20:00-20221028, Nicolas Frayer wrote: > > Quick cosmetics: > linux-arm-kernel@lists.infradead.org (moderated list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS) > is part of the results of get_maintainers.pl why drop not CC it? > > git log --oneline drivers/soc/ti/k3-socinfo.c > soc: ti: k3-socinfo: > > Please fix the $subject > >> Changed the memory and resource allocations in the probe function >> to devm. Also added a remove callback. > > Yes, but why are we doing this change, what benefit do we get by doing > this change? > > >> >> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com> >> --- >> >> v2->v3: >> dropped module conversion part of this series while other driver dependencies >> on socinfo are worked out. >> A dependency issue is introduced by changing subsys_initcall() >> to module_platform_driver(). Some drivers using the socinfo information probe >> before the socinfo driver itself and it makes their probe fail. >> >> Dropped series: >> https://lore.kernel.org/all/20221010131538.7333-1-nfrayer@baylibre.com/ > > OK - if we are'nt going to convert this into modules, then is there a > reason for this patch?
Yeah, Nishanth has a good point here. Lets wait on this patch an included it with the module conversion once we figure out the deferred probe issues around this.
Kevin
| |