Messages in this thread | | | Date | Mon, 31 Oct 2022 04:04:14 -0600 | Subject | Re: [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-pstate-ut | From | Shuah Khan <> |
| |
On 10/31/22 02:49, Meng Li wrote: > Hi all: > > First, rename amd-pstate-ut.sh to basic.sh as a basic test, mainly for > AMD P-State kernel drivers. The purpose of this modification is to > facilitate the subsequent addition of gitsource, tbench and other tests. > > Second, split basic.sh into run.sh and basic.sh. > The modification makes basic.sh more pure, just for test basic kernel > functions. The file of run.sh mainly contains functions such as test > entry, parameter check, prerequisite and log clearing etc. > > Third, add tbench.sh trigger the tbench testing and monitor the cpu. > > Fourth, add gitsource.sh trigger the gitsource testing and monitor the cpu > information. > > Finally, modify rst document to introduce test steps and results etc. >
> > Changes from V4->V5: > - selftests: amd-pstate: > - - rename amd-pstate-ut.sh to basic.sh. > - - split basic.sh into run.sh and basic.sh. > - - modify tbench.sh to prompt to install tbench. > - - modify commit messages and description informations of shell files. > - Documentation: amd-pstate: > - - correct spell errors. >
v5 series looks good. Please cleanup checkpatch errors in a couple of files. Not too concerned about long line warnings as these seem like "echo" statements with output text.
thanks, -- Shuah
| |