lkml.org 
[lkml]   [2022]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 10/13] staging: r8188eu: remove return value from on_action_public_vendor
    Date
    The only caller of on_action_public_vendor does not check the return
    value. We can make it a void function.

    Signed-off-by: Martin Kaiser <martin@kaiser.cx>
    ---
    drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 +++-------
    1 file changed, 3 insertions(+), 7 deletions(-)

    diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
    index b3cef3504ad3..b395457a6a60 100644
    --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
    +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
    @@ -3779,17 +3779,13 @@ static unsigned int on_action_public_p2p(struct recv_frame *precv_frame)
    return _SUCCESS;
    }

    -static unsigned int on_action_public_vendor(struct recv_frame *precv_frame)
    +static void on_action_public_vendor(struct recv_frame *precv_frame)
    {
    - unsigned int ret = _FAIL;
    u8 *pframe = precv_frame->rx_data;
    u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr);

    - if (!memcmp(frame_body + 2, P2P_OUI, 4)) {
    - ret = on_action_public_p2p(precv_frame);
    - }
    -
    - return ret;
    + if (!memcmp(frame_body + 2, P2P_OUI, 4))
    + on_action_public_p2p(precv_frame);
    }

    static unsigned int on_action_public_default(struct recv_frame *precv_frame)
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-10-30 18:35    [W:4.366 / U:0.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site