Messages in this thread | | | Date | Mon, 3 Oct 2022 11:32:58 +0200 | Subject | Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml | From | Krzysztof Kozlowski <> |
| |
On 03/10/2022 10:29, Bhupesh Sharma wrote: > On Sun, 2 Oct 2022 at 13:24, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 01/10/2022 14:51, Bhupesh Sharma wrote: >>>>> Right, most of them are to avoid the make dtbs_check errors / warnings >>>>> like the one mentioned above. >>>> >>>> All of them should not be here. >>> >>> I guess only 'snps,reset-gpio' need not be replicated here, as for >>> others I still see 'dtbs_check' error, if they are not replicated here: >>> >>> >>> arch/arm64/boot/dts/qcom/sm8150-hdk.dtb: ethernet@20000: Unevaluated >>> properties are not allowed ('power-domains', 'resets', 'rx-fifo-depth', >>> 'tx-fifo-depth' were unexpected) >>> From schema: /Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> >>> Am I missing something here? >> >> Probably the snps,dwmac schema failed. It is then considered >> unevaluated, so such properties are unknown for qcom,ethqos schema. Run >> check with snps,dwmac and fix all errors first. > > Running dt_binding_check DT_SCHEMA_FILES=net/snps,dwmac.yaml > reports no error currently.
Then it's something in your commits. I don't know what you wrote, as you did not sent a commit. I cannot reproduce your errors after removing unneeded power-domains.
Just to clarify - I am testing only the dt_binding_check (so only the examples - I assume they are meaningful).
Best regards, Krzysztof
| |