lkml.org 
[lkml]   [2022]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 2/2] Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is present"
    Date
    Hi Andy,

    On Tue, Sep 27, 2022, Andy Shevchenko wrote:
    > This reverts commit 0f01017191384e3962fa31520a9fd9846c3d352f.
    >
    > As pointed out by Ferry this breaks Dual Role support on
    > Intel Merrifield platforms.

    Can you provide more info than this (any debug info/description)? It
    will be difficult to come back to fix with just this to go on. The
    reverted patch was needed to fix a different issue.

    Thanks,
    Thinh

    >
    > Fixes: 0f0101719138 ("usb: dwc3: Don't switch OTG -> peripheral if extcon is present")
    > Reported-by: Ferry Toth <fntoth@gmail.com>
    > Cc: stable@vger.kernel.org
    > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    > Tested-by: Ferry Toth <fntoth@gmail.com> # for Merrifield
    > ---
    > drivers/usb/dwc3/core.c | 55 +----------------------------------------
    > drivers/usb/dwc3/drd.c | 50 +++++++++++++++++++++++++++++++++++++
    > 2 files changed, 51 insertions(+), 54 deletions(-)
    \
     
     \ /
      Last update: 2022-10-03 23:58    [W:4.171 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site