lkml.org 
[lkml]   [2022]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] x86/microcode: Do some minor fixups
    Date
    From: Borislav Petkov <bp@suse.de>

    Improve debugging printks and fixup formatting.

    Signed-off-by: Borislav Petkov <bp@suse.de>
    ---
    arch/x86/kernel/cpu/microcode/core.c | 11 +++++------
    1 file changed, 5 insertions(+), 6 deletions(-)

    diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
    index 7c41e0132fa1..ffb249c29f30 100644
    --- a/arch/x86/kernel/cpu/microcode/core.c
    +++ b/arch/x86/kernel/cpu/microcode/core.c
    @@ -568,6 +568,8 @@ static int mc_cpu_starting(unsigned int cpu)
    {
    enum ucode_state err = microcode_ops->apply_microcode(cpu);

    + pr_debug("%s: CPU%d, err: %d\n", __func__, cpu, err);
    +
    return err == UCODE_ERROR;
    }

    @@ -590,7 +592,7 @@ static int mc_cpu_down_prep(unsigned int cpu)

    /* Suspend is in progress, only remove the interface */
    sysfs_remove_group(&dev->kobj, &mc_attr_group);
    - pr_debug("CPU%d removed\n", cpu);
    + pr_debug("%s: CPU%d\n", __func__, cpu);

    return 0;
    }
    @@ -639,14 +641,11 @@ static int __init microcode_init(void)
    if (!microcode_ops)
    return -ENODEV;

    - microcode_pdev = platform_device_register_simple("microcode", -1,
    - NULL, 0);
    + microcode_pdev = platform_device_register_simple("microcode", -1, NULL, 0);
    if (IS_ERR(microcode_pdev))
    return PTR_ERR(microcode_pdev);

    - error = sysfs_create_group(&cpu_subsys.dev_root->kobj,
    - &cpu_root_microcode_group);
    -
    + error = sysfs_create_group(&cpu_subsys.dev_root->kobj, &cpu_root_microcode_group);
    if (error) {
    pr_err("Error creating microcode group!\n");
    goto out_pdev;
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-10-28 16:28    [W:2.886 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site