Messages in this thread | | | Date | Fri, 28 Oct 2022 14:55:37 +0200 | Subject | Re: [PATCH v2 32/32] dmaengine: at_hdmac: Convert driver to use virt-dma | From | Nicolas Ferre <> |
| |
On 25/10/2022 at 11:03, Tudor Ambarus wrote: > Convert the driver to use the core virt-dma. The driver will be easier to > maintain as it uses the list handling and the tasklet from virt-dma. > > With the conversion replace the election of a new transfer in the tasklet > with the election of the new transfer in the interrupt handler. With this > we have a shorter idle window as we remove the scheduling latency of the > tasklet. I chose to do this while doing the conversion to virt-dma, > because if I made a prerequisite patch with the new transfer election in > the irq handler, I would have to duplicate some virt-dma code in the > at_hdmac driver that would end up being removed at the virt-dma conversion > anyway. So do this in a single step. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Even if it's difficult to review, I support the transition: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Tudor, regards, Nicolas
[..]
-- Nicolas Ferre
| |