lkml.org 
[lkml]   [2022]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support
From


On 10/28/2022 2:48 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 27/10/2022 01:12, Vidya Sagar wrote:
>> Add support for ECAM aperture for Tegra234.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml | 10 ++++++++--
>> .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
>> 2 files changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> index 75da3e8eecb9..15cc2d2055bb 100644
>> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> @@ -27,6 +27,7 @@ properties:
>> - nvidia,tegra234-pcie
>>
>> reg:
>> + minItems: 4
>> items:
>> - description: controller's application logic registers
>> - description: configuration registers
>> @@ -35,13 +36,17 @@ properties:
>> available for software access.
>> - description: aperture where the Root Port's own configuration
>> registers are available.
>> + - description: aperture to access the configuration space through ECAM.
>> + This is applicable only for Tegra234.
>
> Then restrict it per compatible in allOf
>

Thanks Krzysztof for your review.
For a similar change here
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20220707081301.29961-3-vidyas@nvidia.com/
Rob had said that may be it is not worth it.
Let me know if you really want this change and I'll push a new patch.

Thanks,
Vidya Sagar

>>
>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2022-10-28 14:11    [W:0.080 / U:1.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site