Messages in this thread | | | Date | Fri, 28 Oct 2022 12:07:38 +0100 | Subject | Re: [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding | From | Jon Hunter <> |
| |
On 28/10/2022 10:25, Jon Hunter wrote: > > On 28/10/2022 03:19, Krzysztof Kozlowski wrote: >> On 25/10/2022 04:02, Wayne Chang wrote: >>> >>>>> + power-domain-names: >>>>> + items: >>>>> + - const: xusb_host >>>>> + - const: xusb_ss >>>> >>>> Drop 'xusb_'. >>> >>> The properties are constant and we use the name to get the power domain. >>> >>> tegra->genpd_dev_host = dev_pm_domain_attach_by_name(dev, >>> "xusb_host"); >>> >>> tegra->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "xusb_ss"); >>> >>> we might not be able to drop the xusb_ >> >> These are new bindings, so why do say they are "constant"? New bindings >> means you did not use them. If you used them before bindings... what can >> we say? Don't? > > Not exactly. However, what we should do here is convert the legacy > binding doc [0] and replace with this one. But yes we are stuck with the > 'xusb_host' naming.
Thierry already has a patch to do this [0]. So we should fix that up and included in this series.
Jon
[0] https://lore.kernel.org/linux-tegra/20211209165339.614498-3-thierry.reding@gmail.com/
-- nvpublic
| |