Messages in this thread Patch in this message | | | From | Yu Kuai <> | Subject | [PATCH -next 3/5] blk-iocost: don't allow to configure bio based device | Date | Fri, 28 Oct 2022 18:10:54 +0800 |
| |
From: Yu Kuai <yukuai3@huawei.com>
iocost is based on rq_qos, which can only work for request based device, thus it doesn't make sense to configure iocost for bio based device.
Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- block/blk-iocost.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index c532129a1456..2bfecc511dd9 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -3181,6 +3181,11 @@ static ssize_t ioc_qos_write(struct kernfs_open_file *of, char *input, return PTR_ERR(bdev); disk = bdev->bd_disk; + if (!queue_is_mq(disk->queue)) { + ret = -EPERM; + goto out; + } + ioc = q_to_ioc(disk->queue); if (!ioc) { ret = blk_iocost_init(disk); @@ -3364,6 +3369,11 @@ static ssize_t ioc_cost_model_write(struct kernfs_open_file *of, char *input, return PTR_ERR(bdev); q = bdev_get_queue(bdev); + if (!queue_is_mq(q)) { + ret = -EPERM; + goto out; + } + ioc = q_to_ioc(q); if (!ioc) { ret = blk_iocost_init(bdev->bd_disk); -- 2.31.1
| |