Messages in this thread | | | Date | Fri, 28 Oct 2022 13:10:28 -0700 | Subject | Re: [PATCH 1/2] efi/cper, cxl: Decode CXL Protocol Error Section | From | Smita Koralahalli <> |
| |
On 10/10/2022 7:24 AM, Jonathan Cameron wrote: > On Fri, 7 Oct 2022 21:17:13 +0000 > Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com> wrote: > >> Add support for decoding CXL Protocol Error Section as defined in UEFI 2.9 >> Section N.2.13. >> >> Do the section decoding in a new cper_cxl.c file. This new file will be >> used in the future for more CXL CPERs decode support. Add this to the >> existing UEFI_CPER config. >> >> Decode only the fields that are useful to parse the error. >> >> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com> > Hi Smita, > > A few comments inline, but this looks pretty good to me though lots to > build on top of this (trace events, any in kernel handling necessary etc). > > Jonathan > > >> +}; >> + >> +#pragma pack() > I would push the structure definition down into the c file and provide a forwards > definition only in the header. > > struct cper_sec_prot_err; >
I haven't done this in my v2. In efi/cper.c, I'm calculating the size of the struct. I think forward structure cannot be laid out there as size isn't known. Please correct me if I'm wrong. I can incorporate changes accordingly in my v3.
Thanks, Smita
>> + >> +void cper_print_prot_err(const char *pfx, const struct cper_sec_prot_err *prot_err); >> + >> +#endif //__CPER_CXL_
| |