Messages in this thread | | | From | Sven van Ashbrook <> | Date | Thu, 27 Oct 2022 11:51:15 -0400 | Subject | Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN() |
| |
On Thu, Oct 27, 2022 at 11:47 AM Limonciello, Mario <Mario.Limonciello@amd.com> wrote: > > If we do make changes to this message level so that other infrastructure picks up I suggest > we do it for both drivers.
Sounds good, patch feedback willing.
> WARN() is really only intended for internal kernel bugs and not for > hw misbehaving, so I'm not a fan of the change you are suggesting here.
Thanks, I was not aware of this distinction. But it does look like upper-case WARN is already used in many places to indicate hw misbehaving?
Here for example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/chrome/cros_ec.c?h=v6.1-rc2#n142
| |