| Date | Thu, 27 Oct 2022 14:18:03 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 11/16] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init |
| |
On Tue, Oct 04, 2022 at 10:10:18AM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c > index 49b60a427fc9..330aa412be63 100644 > --- a/arch/x86/kernel/cpu/cacheinfo.c > +++ b/arch/x86/kernel/cpu/cacheinfo.c > @@ -1137,3 +1137,10 @@ void cache_cpu_init(void) > cache_enable(); > local_irq_restore(flags); > } > + > +bool cache_aps_delayed_init;
Why isn't that static and only the accessors set it or clear it?
> +void set_cache_aps_delayed_init(void) > +{ > + cache_aps_delayed_init = true; > +}
Otherwise, there's no point for this thing.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|