Messages in this thread | | | Date | Thu, 27 Oct 2022 10:05:58 +0200 | From | Michal Koutný <> | Subject | Re: [PATCH] cgroup: Simplify code in css_set_move_task |
| |
Hello.
On Thu, Oct 20, 2022 at 07:47:01AM +0000, "haifeng.xu" <haifeng.xu@shopee.com> wrote: > - lockdep_assert_held(&css_set_lock); > + if (!cset || css_set_populated(cset)) > + return;
1) the guard should be css_set_populated() ^ populated (when unsetting the populated trait)
2) I'd keep the lockdep_assert_held() after it anyway.
Also the commit message should explain what's the reason to move css_set_populated() after css_set_move_task().
Thanks, Michal [unhandled content-type:application/pgp-signature] | |