Messages in this thread | | | Date | Thu, 27 Oct 2022 22:01:05 -0400 | Subject | Re: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema | From | Krzysztof Kozlowski <> |
| |
On 26/10/2022 23:01, Joy Zou wrote: > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2022年10月26日 22:59 >> To: Joy Zou <joy.zou@nxp.com>; vkoul@kernel.org; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com >> Cc: S.J. Wang <shengjiu.wang@nxp.com>; martink@posteo.de; >> dev@lynxeye.de; alexander.stein@ew.tq-group.com; Peng Fan >> <peng.fan@nxp.com>; david@ixit.cz; aford173@gmail.com; Hongxing Zhu >> <hongxing.zhu@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> dmaengine@vger.kernel.org; devicetree@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma >> to DT schema >> >> Caution: EXT Email >> >> On 25/10/2022 04:36, Joy Zou wrote: >>> Convert the i.MX SDMA binding to DT schema format using json-schema. >>> >>> The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma, >>> fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to >>> delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and >>> fsl,imx6sl-sdma are added. The original binding don't list all compatible used. >>> >>> In addition, add new peripheral types HDMI Audio. >>> >>> Signed-off-by: Joy Zou <joy.zou@nxp.com> >>> --- >>> Changes in v8: >>> add the dma-controller quotes. >> >> Why adding quotes? > I refer to your comments in patch v7/1. The comment as follow: > +maintainers: > + - Joy Zou <joy.zou@nxp.com> > + > You need to reference dma-controller.yaml schema.
Yes, you need to reference dma-controller.yaml. Nothing about quotes. Reference is "$ref: .....yaml"
> +properties: > + compatible: > + one of: > I misunderstand that add the dma-controller.yaml quotes.
There was nothing about quotes - ".
> So I am a little confused. Now, I see. > should I add dma-common.yaml quotes but not the dma-controller?
Just drop "
https://en.wikipedia.org/wiki/Quotation_mark
Best regards, Krzysztof
| |