lkml.org 
[lkml]   [2022]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 0/2] squashfs: Add the mount parameter "threads="
From
On 19/10/2022 04:09, Xiaoming Ni wrote:
> Currently, Squashfs supports multiple decompressor parallel modes. However, this
> mode can be configured only during kernel building and does not support flexible
> selection during runtime.
>
> In the current patch set, the mount parameter "threads=" is added to allow users
> to select the parallel decompressor mode and configure the number of decompressors
> when mounting a file system.
>
> "threads=<single|multi|percpu|1|2|3|...>"
> The upper limit is num_online_cpus() * 2.
>
> v6: fix opt->thread_ops unassigned if CONFIG_SQUASHFS_CHOICE_DECOMP_BY_MOUNT is not set.
>

This version looks good to me. Thanks.

Reviewed-by: Phillip Lougher <phillip@squashfs.org.uk>

> v5: https://lore.kernel.org/lkml/20220930091406.50869-1-nixiaoming@huawei.com/
> fix a low-level mistake in patching:
> fs/squashfs/super.c:492:7: warning: "CONFIG_SQUASHFS_DECOMP_MULTI" is
> not defined, evaluates to 0 [-Wundef]
>
> v4: https://lore.kernel.org/lkml/20220916083604.33408-1-nixiaoming@huawei.com/
> Based on Philip Lougher's suggestion, make the following updates:
> 1. Use static modifiers to avoid changing symbol names.
> 2. Fixed some formatting issues
>
> v3: https://lore.kernel.org/lkml/20220902094855.22666-1-nixiaoming@huawei.com/
> Based on Philip Lougher's suggestion, make the following updates:
> 1. The default configuration is the same as that before the patch installation.
> 2. Compile the three decompression modes when the new configuration is enabled.
> 3. "threads=1" supports only the SQUASHFS_DECOMP_SINGLE mode.
>
> v2: https://lore.kernel.org/lkml/20220816010052.15764-1-nixiaoming@huawei.com/
> fix warning: sparse: incorrect type in initializer (different address spaces)
> Reported-by: kernel test robot <lkp@intel.com>
>
> v1: https://lore.kernel.org/lkml/20220815031100.75243-1-nixiaoming@huawei.com/
> *** BLURB HERE ***
>
> Xiaoming Ni (2):
> squashfs: add the mount parameter theads=<single|multi|percpu>
> squashfs: Allows users to configure the number of decompression
> threads
>
> fs/squashfs/Kconfig | 51 +++++++++++--
> fs/squashfs/block.c | 2 +-
> fs/squashfs/decompressor.c | 2 +-
> fs/squashfs/decompressor_multi.c | 20 +++--
> fs/squashfs/decompressor_multi_percpu.c | 23 ++++--
> fs/squashfs/decompressor_single.c | 15 +++-
> fs/squashfs/squashfs.h | 23 ++++--
> fs/squashfs/squashfs_fs_sb.h | 4 +-
> fs/squashfs/super.c | 97 ++++++++++++++++++++++++-
> 9 files changed, 203 insertions(+), 34 deletions(-)
>

\
 
 \ /
  Last update: 2022-10-28 00:45    [W:0.140 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site