Messages in this thread | | | Date | Wed, 26 Oct 2022 08:58:10 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH 1/1] net/mlx5: update debug log level for remote access error syndromes |
| |
On Wed, Oct 26, 2022 at 08:48:13AM +0300, Leon Romanovsky wrote: > On Tue, Oct 25, 2022 at 02:22:01AM -0700, Arumugam Kolappan wrote: > > The mlx5 driver dumps the entire CQE buffer by default for few syndromes. > > Some syndromes are expected due to the application behavior [ex: > > MLX5_CQE_SYNDROME_REMOTE_ACCESS_ERR, MLX5_CQE_SYNDROME_REMOTE_OP_ERR and > > MLX5_CQE_SYNDROME_LOCAL_PROT_ERR]. Hence, for these syndromes, the patch > > converts the log level from KERN_WARNING to KERN_DEBUG. This enables the > > application to get the CQE buffer dump by changing to KERN_DEBUG level > > as and when needed. > > > > Suggested-by: Leon Romanovsky <leon@kernel.org> > > Signed-off-by: Arumugam Kolappan <aru.kolappan@oracle.com> > > --- > > drivers/infiniband/hw/mlx5/cq.c | 30 ++++++++++++++++++++++-------- > > 1 file changed, 22 insertions(+), 8 deletions(-)
And more general comments: 1. Patch title is "RDMA/mlx5: Update ...." and not "net/mlx5: updated ..." 2. No need 1/1 notation for single patch 3. [PATCH ...] is better to include target [PATCH rdma-next ...]
Thanks
| |