Messages in this thread | | | From | <> | Subject | Re: [net-next v3 2/6] net: dcb: add new apptrust attribute | Date | Wed, 26 Oct 2022 12:10:23 +0000 |
| |
> > + if (ops->dcbnl_getapptrust) { > > + u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0}; > > + int nselectors; > > + > > + apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE); > > + if (!app) > > + return -EMSGSIZE; > > + > > + err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors); > > + if (err) > > + return -EMSGSIZE; > > This should return the error coming from the driver instead of > -EMSGSIZE.
Hmm. The question is whether we should return at all if dcbnl_getapptrust() fails, or just continue to fill whatever other ieee information is available? Seems to be like the rest of the code in ieee_fill() just ignore that error.
> > Also, it should cancel the nest before returning.
Ack.
| |