Messages in this thread | | | Date | Wed, 26 Oct 2022 10:18:06 +0200 | Subject | Re: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the APCB | From | Pierre Morel <> |
| |
On 10/25/22 18:20, Claudio Imbrenda wrote: > On Tue, 25 Oct 2022 15:17:36 +0200 > Pierre Morel <pmorel@linux.ibm.com> wrote: > >> On 10/25/22 11:30, David Hildenbrand wrote: >>> On 25.10.22 11:13, Pierre Morel wrote: >>>> The APCB is part of the CRYCB. >>>> The calculation of the APCB origin can be done by adding >>>> the APCB offset to the CRYCB origin. >>>> >>>> Current code makes confusing transformations, converting >>>> the CRYCB origin to a pointer to calculate the APCB origin. >>>> >>> >>> >>> While at it, can we rename "crycb_o" to "crycb_gpa" and "apcb_o" to >>> "apcb_gpa". >>> >>> These are not pointers but guest physical addresses. >>> >> >> I can do that. >> the _o came from the name in the documentation "origin" >> but gpa is more obvious. >> > > with that fixed: > > Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Thanks, Pierre
-- Pierre Morel IBM Lab Boeblingen
| |