Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 26 Oct 2022 10:07:43 +0200 | Subject | Re: [PATCH v1 8/8] lsm: wireup syscalls lsm_self_attr and lsm_module_list |
| |
Hi Casey,
CC linux-perf
On Tue, Oct 25, 2022 at 8:52 PM Casey Schaufler <casey@schaufler-ca.com> wrote: > Wireup two syscalls for Linux Security Modules. > > Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Thanks for your patch!
> arch/m68k/kernel/syscalls/syscall.tbl | 2 ++
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> # m68k
> --- a/arch/arm64/include/asm/unistd32.h > +++ b/arch/arm64/include/asm/unistd32.h > @@ -907,6 +907,8 @@ __SYSCALL(__NR_process_mrelease, sys_process_mrelease) > __SYSCALL(__NR_futex_waitv, sys_futex_waitv) > #define __NR_set_mempolicy_home_node 450 > __SYSCALL(__NR_set_mempolicy_home_node, sys_set_mempolicy_home_node) > +#define __NR_lsm_attr_set 451 > +__SYSCALL(__NR_lsm_attr_set, sys_lsm_attr_set)
Missing lsm_module_list.
> > /* > * Please add new compat syscalls above this comment and update
> --- a/include/uapi/asm-generic/unistd.h > +++ b/include/uapi/asm-generic/unistd.h > @@ -886,8 +886,11 @@ __SYSCALL(__NR_futex_waitv, sys_futex_waitv) > #define __NR_set_mempolicy_home_node 450 > __SYSCALL(__NR_set_mempolicy_home_node, sys_set_mempolicy_home_node) > > +#define __NR_lsm_self_attr 451 > +__SYSCALL(__NR_lsm_self_attr, sys_lsm_self_attr)
Missing lsm_module_list.
> + > #undef __NR_syscalls > -#define __NR_syscalls 451 > +#define __NR_syscalls 452
Hence one off.
> --- a/tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl > +++ b/tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl > @@ -365,3 +365,5 @@ > 448 n64 process_mrelease sys_process_mrelease > 449 n64 futex_waitv sys_futex_waitv > 450 common set_mempolicy_home_node sys_set_mempolicy_home_node > +451 n64 lsm_self_attr sys_lsm_self_attr > +452 n64 lsm_module_list sys_lsm_module_list > diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > index 2bca64f96164..7b779080acbe 100644 > --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > +++ b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > @@ -530,3 +530,5 @@ > 448 common process_mrelease sys_process_mrelease > 449 common futex_waitv sys_futex_waitv > 450 nospu set_mempolicy_home_node sys_set_mempolicy_home_node > +451 common lsm_self_attr sys_lsm_self_attr > +452 common lsm_module_list sys_lsm_module_list > diff --git a/tools/perf/arch/s390/entry/syscalls/syscall.tbl b/tools/perf/arch/s390/entry/syscalls/syscall.tbl > index 799147658dee..eaba1ed5654e 100644 > --- a/tools/perf/arch/s390/entry/syscalls/syscall.tbl > +++ b/tools/perf/arch/s390/entry/syscalls/syscall.tbl > @@ -453,3 +453,5 @@ > 448 common process_mrelease sys_process_mrelease sys_process_mrelease > 449 common futex_waitv sys_futex_waitv sys_futex_waitv > 450 common set_mempolicy_home_node sys_set_mempolicy_home_node sys_set_mempolicy_home_node > +451 common lsm_self_attr sys_lsm_self_attr sys_lsm_self_attr > +452 common lsm_module_list sys_lsm_module_list sys_lsm_module_list > diff --git a/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl b/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl > index c84d12608cd2..40b35e7069a7 100644 > --- a/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl > @@ -372,6 +372,8 @@ > 448 common process_mrelease sys_process_mrelease > 449 common futex_waitv sys_futex_waitv > 450 common set_mempolicy_home_node sys_set_mempolicy_home_node > +451 common lsm_self_attr sys_lsm_self_attr > +452 common lsm_module_list sys_lsm_module_list
BTW, why are the syscall tables not shared between arch/ and tools/perf/? They seem to be identical (except for ppc due to 32/64 vs. common)?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |