Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 26 Oct 2022 09:56:22 +0200 | Subject | Re: [PATCH v2 1/2] clk: renesas: rzg2l: Don't assume all CPG_MOD clocks support PM |
| |
Hi Prabhakar,
On Wed, Oct 26, 2022 at 3:42 AM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > There are cases where not all CPG_MOD clocks should be assumed to support > PM. For example on the CRU block there is a particular sequence that needs > to be followed to initialize the CSI-2 D-PHY in which individual clocks > need to be turned ON/OFF, due to which Runtime PM support wasn't used by > the CRU CSI-2 driver. > > This patch adds support to allow indicating if PM is not supported by the > CPG_MOD clocks. Two new members no_pm_mod_clks and num_no_pm_mod_clks are > added to struct rzg2l_cpg_info so that MOD clocks which do not support PM > can be passed by no_pm_mod_clks[] array and when the driver uses Runtime > PM support the clk ID is matched against the no_pm_mod_clks[] array to see > if the clk is needed to be included as part of Runtime PM. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v1->v2 > * Dropped DEF_NO_PM() macro > * Added genpd member to struct rzg2l_cpg_priv > * Added no_pm_mod_clks and num_no_pm_mod_clks members > to struct rzg2l_cpg_info > * Updated commit message
Thanks for the update!
> --- a/drivers/clk/renesas/rzg2l-cpg.c > +++ b/drivers/clk/renesas/rzg2l-cpg.c
> > static int rzg2l_cpg_attach_dev(struct generic_pm_domain *unused, struct device *dev)
Time to rename "unused" to "domain" ;-)
> { > + struct rzg2l_cpg_priv *priv = container_of(unused, struct rzg2l_cpg_priv, genpd);
I can fix that while applying...
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |