Messages in this thread | | | Date | Wed, 26 Oct 2022 22:48:07 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH v4 2/4] kvm: Add KVM_PFN_ERR_SIGPENDING |
| |
Uber nit, s/kvm/KVM for the shortlog,
On Tue, Oct 11, 2022, Peter Xu wrote: > Add a new pfn error to show that we've got a pending signal to handle
Please avoid pronouns in changelogs and comments, they're unnecessarily ambiguous. E.g.
Add a new pfn error to capture that hva_to_pfn_slow() failed due to a pending signal. The new error will be used in future patches to propagate -EINTR back to userspace instead of returning -EFAULT.
> during hva_to_pfn_slow() procedure (of -EINTR retval). > > Signed-off-by: Peter Xu <peterx@redhat.com> > ---
Nits aside,
Reviewed-by: Sean Christopherson <seanjc@google.com>
| |