lkml.org 
[lkml]   [2022]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the APCB
On Tue, 25 Oct 2022 15:17:36 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:

> On 10/25/22 11:30, David Hildenbrand wrote:
> > On 25.10.22 11:13, Pierre Morel wrote:
> >> The APCB is part of the CRYCB.
> >> The calculation of the APCB origin can be done by adding
> >> the APCB offset to the CRYCB origin.
> >>
> >> Current code makes confusing transformations, converting
> >> the CRYCB origin to a pointer to calculate the APCB origin.
> >>
> >
> >
> > While at it, can we rename "crycb_o" to "crycb_gpa" and "apcb_o" to
> > "apcb_gpa".
> >
> > These are not pointers but guest physical addresses.
> >
>
> I can do that.
> the _o came from the name in the documentation "origin"
> but gpa is more obvious.
>

with that fixed:

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

\
 
 \ /
  Last update: 2022-10-25 18:24    [W:0.167 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site