lkml.org 
[lkml]   [2022]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 5/5] arm64: dts: apple: Add CPU topology & cpufreq nodes for t8103
    From
    On 24/10/2022 00:39, Hector Martin wrote:
    > Add the missing CPU topology/capacity information and the cpufreq nodes,
    > so we can have CPU frequency scaling and the scheduler has the
    > information it needs to make the correct decisions.
    >

    Thank you for your patch. There is something to discuss/improve.

    > +
    > timer {
    > compatible = "arm,armv8-timer";
    > interrupt-parent = <&aic>;
    > @@ -124,6 +298,18 @@ soc {
    > ranges;
    > nonposted-mmio;
    >
    > + cpufreq_e: cpufreq@210e20000 {

    Node name: performance-controller

    > + compatible = "apple,t8103-cluster-cpufreq", "apple,cluster-cpufreq";
    > + reg = <0x2 0x10e20000 0 0x1000>;
    > + #performance-domain-cells = <0>;
    > + };
    > +
    > + cpufreq_p: cpufreq@211e20000 {

    Ditto

    > + compatible = "apple,t8103-cluster-cpufreq", "apple,cluster-cpufreq";
    > + reg = <0x2 0x11e20000 0 0x1000>;
    > + #performance-domain-cells = <0>;
    > + };
    > +
    Krzysztof

    \
     
     \ /
      Last update: 2022-10-25 18:03    [W:3.672 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site