Messages in this thread | | | Date | Tue, 25 Oct 2022 15:00:10 +0200 | Subject | Re: [PATCH] video: fbdev: sis: use explicitly signed char | From | Helge Deller <> |
| |
On 10/25/22 14:55, Jason A. Donenfeld wrote: > On Mon, Oct 24, 2022 at 8:29 PM Helge Deller <deller@gmx.de> wrote: >> >> On 10/24/22 18:29, Jason A. Donenfeld wrote: >>> With char becoming unsigned by default, and with `char` alone being >>> ambiguous and based on architecture, signed chars need to be marked >>> explicitly as such. This fixes warnings like: >>> >>> drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned >>> >>> Cc: Thomas Winischhofer <thomas@winischhofer.net> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Helge Deller <deller@gmx.de> >>> Cc: linux-usb@vger.kernel.org >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: dri-devel@lists.freedesktop.org >>> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> >> >> Applied to linux-fbdev git tree. > > For 6.1 as a fix, right? Since this is already broken on, e.g., ARM.
Yes.
Helge
| |