lkml.org 
[lkml]   [2022]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware/psci: demote suspend-mode warning to debug level
On Tue, Oct 25, 2022 at 12:53:55PM +0100, Sudeep Holla wrote:
> On Mon, Oct 24, 2022 at 04:34:17PM +0200, Johan Hovold wrote:
> > On some Qualcomm platform, like SC8280XP, the attempt to set PC mode
> > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb
> > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this
> > is now logged at warning level:
> >
> > psci: failed to set PC mode: -3
> >
> > As there is nothing users can do about the firmware behaving this way,
> > demote the warning to debug level.
> >
>
> As mentioned in the other thread I prefer to keep this as error as we
> shouldn't mask this error and enable more/newer platforms to ignore it
> when they can go and fix it. So I don't agree with this.

But now every owner of an X13s laptop will see this not very informative
error at every boot and wonder what it means. Has something gone broken?
Should they be worried? Can something be done about it?

Remember that this is firmware used by Windows machines so by the time
we see this in Linux it's probably way too late to fix in firmware
anyway.

Johan

\
 
 \ /
  Last update: 2022-10-25 15:01    [W:1.349 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site