Messages in this thread | | | Date | Tue, 25 Oct 2022 14:10:50 +0200 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH v2] misc: sgi-gru: use explicitly signed char |
| |
On Tue, Oct 25, 2022 at 09:38:45AM +0200, Greg Kroah-Hartman wrote: > On Tue, Oct 25, 2022 at 04:52:23AM +0200, Jason A. Donenfeld wrote: > > With char becoming unsigned by default, and with `char` alone being > > ambiguous and based on architecture, signed chars need to be marked > > explicitly as such. This fixes warnings like: > > > > drivers/misc/sgi-gru/grumain.c:711 gru_check_chiplet_assignment() warn: 'gts->ts_user_chiplet_id' is unsigned > > > > Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > > --- > > drivers/misc/sgi-gru/grumain.c | 6 +++--- > > drivers/misc/sgi-gru/grutables.h | 14 +++++++------- > > 2 files changed, 10 insertions(+), 10 deletions(-) > > Hi, > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > a patch that has triggered this response. He used to manually respond > to these common problems, but in order to save his sanity (he kept > writing the same thing over and over, yet to different people), I was > created. Hopefully you will not take offence and will fix the problem > in your patch and resubmit it so that it can be accepted into the Linux > kernel tree. > > You are receiving this message because of the following common error(s) > as indicated below: > > - This looks like a new version of a previously submitted patch, but you > did not list below the --- line any changes from the previous version. > Please read the section entitled "The canonical patch format" in the > kernel file, Documentation/SubmittingPatches for what needs to be done > here to properly describe this.
I fixed the kbuild errors that v2 was a reply to. Specifically, I fixed up the function prototypes in grutables.h.
Jason
| |