Messages in this thread | | | Date | Tue, 25 Oct 2022 12:14:19 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 04/11] ARM: sa1100: make cpufreq driver build standalone |
| |
On Tue, Oct 25, 2022, at 10:28, Russell King (Oracle) wrote: > On Fri, Oct 21, 2022 at 05:49:34PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> Commit 59a2e613d07f ("cpufreq: sa11x0: move cpufreq driver >> to drivers/cpufreq") added an unnecessary reference to >> mach/generic.h. Just remove it again after moving the code >> into the corresponding driver. > > So how does arch/arm/mach-sa1100/clock.c get the MPLL rate with this > change?
You are right, that's broken. It works for the defconfigs that enable the cpufreq driver, but it seems I need to improve my randconfig build testing to make sure I find problems like this sooner.
I don't think anything depends on this patch, so I've dropped it from my series now.
Thanks,
Arnd
| |